src/main/webapp/app/exam/participate/exam-start-information/exam-start-information.component.ts (1)

Line range hint 51-62: Add null checks for optional properties

The updateInformationBoxes method should include null checks for optional properties to prevent potential runtime errors.

     private updateInformationBoxes(): void {
+        if (!this.exam || !this.studentExam) {
+            return;
+        }
         this.totalPoints = this.exam.examMaxPoints;
         this.totalWorkingTimeInMinutes = Math.floor(this.exam.workingTime! / 60);
         this.moduleNumber = this.exam.moduleNumber;
         this.courseName = this.exam.courseName;
         this.examiner = this.exam.examiner;
         this.numberOfExercisesInExam = this.exam.numberOfExercisesInExam;
         this.examinedStudent = this.studentExam.user?.name;
         this.startDate = this.exam.startDate;
-        this.gracePeriodInMinutes = Math.floor(this.exam.gracePeriod! / 60);
+        this.gracePeriodInMinutes = this.exam.gracePeriod ? Math.floor(this.exam.gracePeriod / 60) : undefined;

src/main/webapp/app/exam/participate/exam-participation.component.ts (1)

674-674: Simplify object property assignment using ES6 shorthand

You can use ES6 property shorthand to make the code more concise.

Apply this diff to simplify the object assignment:

- this.exam = { ...this.exam, startDate: startDate, endDate: endDate };
+ this.exam = { ...this.exam, startDate, endDate };

src/test/javascript/spec/component/exam/participate/exam-participation.component.spec.ts (1)

155-158: Ensure consistent use of date handling in tests

The use of dayjs() is appropriate for mocking dates. However, ensure that all test cases consistently use the mocked server date to prevent flakiness.

No action needed if consistency is already maintained across tests.

src/main/java/de/tum/cit/aet/artemis/exam/dto/examevent/ExamRescheduledEventDTO.java (1)

14-14: Consider using Instant for date fields for consistency

To maintain consistency with other DTOs and avoid potential serialization issues, consider using Instant instead of ZonedDateTime for newStartDate and newEndDate.

Apply this diff to replace ZonedDateTime with Instant:

- public record ExamRescheduledEventDTO(Long id, String createdBy, Instant createdDate, ZonedDateTime newStartDate, ZonedDateTime newEndDate) implements ExamLiveEventBaseDTO {
+ public record ExamRescheduledEventDTO(Long id, String createdBy, Instant createdDate, Instant newStartDate, Instant newEndDate) implements ExamLiveEventBaseDTO {

src/main/webapp/app/exam/shared/events/exam-live-event.component.scss (1)

47-57: Reduce style duplication using a shared class

The .wt-title styles are duplicated between .workingTimeUpdate and .examRescheduled classes.

Extract common styles:

+    %event-title {
+        font-weight: bold;
+        font-size: 1.5em;
+        text-align: center;
+        margin-bottom: 15px;
+    }

    &.workingTimeUpdate {
        background-color: var(--artemis-alert-warning-background);
        border-color: var(--artemis-alert-warning-border);

        .wt-title {
-            font-weight: bold;
-            font-size: 1.5em;
-            text-align: center;
-            margin-bottom: 15px;
+            @extend %event-title;
        }
    }

    &.examRescheduled {
        background-color: var(--artemis-alert-warning-background);
        border-color: var(--artemis-alert-warning-border);

        .wt-title {
-            font-weight: bold;
-            font-size: 1.5em;
-            text-align: center;
-            margin-bottom: 15px;
+            @extend %event-title;
        }
    }

src/main/webapp/app/exam/participate/events/exam-live-events-button.component.ts (1)

17-21: Consider improving constant name and adding documentation

While the separation of events is logical, the purpose of USER_DISPLAY_RELEVANT_EVENTS_REOPEN is not immediately clear. Consider:

1. Renaming to something more descriptive like EXAM_PRE_START_RELEVANT_EVENTS
2. Adding JSDoc comments explaining when each constant should be used

-export const USER_DISPLAY_RELEVANT_EVENTS_REOPEN = [
+/** Events that are relevant before the exam starts and can trigger reopening of the event dialog */
+export const EXAM_PRE_START_RELEVANT_EVENTS = [

src/main/webapp/app/exam/shared/events/exam-live-event.component.html (1)

74-82: LGTM with a minor accessibility enhancement suggestion

The implementation of the exam rescheduled event case is correct and follows Angular best practices. Consider adding an ARIA label for better screen reader support.

             @case (ExamLiveEventType.EXAM_RESCHEDULED) {
                 <div>
                     <div
                         [jhiTranslate]="'artemisApp.exam.events.messages.examRescheduled.description'"
                         [translateValues]="{ startDate: examRescheduledEvent.newStartDate | artemisDate, endDate: examRescheduledEvent.newEndDate | artemisDate }"
                         class="wt-title"
+                        role="alert"
+                        aria-live="polite"
                     ></div>
                 </div>
             }

src/main/webapp/app/exam/participate/exam-start-information/exam-start-information.component.ts (1)

35-40: Consider optimizing change detection

While the implementation is correct, consider adding change detection optimization to prevent unnecessary updates:

-    ngOnChanges(): void {
+    ngOnChanges(changes: SimpleChanges): void {
+        // Only update if exam or studentExam inputs have changed
+        if (changes['exam'] || changes['studentExam']) {
           this.updateInformationBoxes();
+        }
     }

src/main/webapp/app/exam/participate/exam-participation-live-events.service.ts (1)

56-59: Consider timezone handling for dates

The date fields should explicitly handle timezone conversions to prevent any potential timezone-related issues.

Consider using a utility function:

 export type ExamRescheduledEvent = ExamLiveEvent & {
-    newStartDate: dayjs.Dayjs;
-    newEndDate: dayjs.Dayjs;
+    newStartDate: dayjs.Dayjs & { utc: true };
+    newEndDate: dayjs.Dayjs & { utc: true };
 };

src/main/webapp/i18n/en/exam.json (1)

190-191: Enhance message clarity

The current message could be more informative about the implications of the rescheduling.

Consider this improved message:

-                    "examRescheduled": "Exam rescheduled"
+                    "examRescheduled": "Exam schedule changed"
                     "description": "The exam has been rescheduled.<br />The exam will take place from {{ startDate }} to {{ endDate }}.<br />The working time has not been affected."
+                    "description": "Important: The exam schedule has been updated.<br />New exam time: {{ startDate }} to {{ endDate }}.<br />Note: Your allocated working time remains unchanged. Please adjust your schedule accordingly."

Also applies to: 211-212

src/main/java/de/tum/cit/aet/artemis/exam/service/ExamService.java (1)

1450-1451: Improve clarity of comments and conditions.

The current comment and condition could be more explicit about the logic:

-// If the old working time equals the new working time, the exam has been rescheduled
-if (studentExam.getWorkingTime().equals(originalStudentWorkingTime)) {
+// If the working time hasn't changed, this update is for rescheduling the exam dates
+if (Objects.equals(studentExam.getWorkingTime(), originalStudentWorkingTime)) {

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

Learnt from: SamuelRoettgermann
PR: ls1intum/Artemis#9303
File: src/main/java/de/tum/in/www1/artemis/service/exam/StudentExamService.java:266-267
Timestamp: 2024-11-12T12:51:58.050Z
Learning: When reviewing code in this project, avoid suggesting code changes that are outside the scope of the PR.

#!/bin/bash
# Search for other places where exam rescheduling is handled to verify consistency
rg -A 5 "exam.*reschedul" 

# Search for test cases to verify the rescheduling logic
ast-grep --pattern 'test.*reschedul.*exam'